Changeset 805 for trunk/zoo-project/zoo-kernel/server_internal.c

Timestamp:

Jan 22, 2017, 5:32:02 PM (7 years ago)

Author:

djay

Message:

Return default iotype if no value has been provided. Fix potential segfault in case tmpIoType is null.

File:

• trunk/zoo-project/zoo-kernel/server_internal.c (modified) (1 diff)

trunk/zoo-project/zoo-kernel/server_internal.c

@@ -791 +791 @@
          * check for useMapServer presence
          */
-        map* tmpCheck=getMap(tmpIoType->content,"useMapServer");
-        if(tmpCheck!=NULL){
-          // Get the default value
-          tmpIoType=getIoTypeFromElement(tmpInputs,tmpInputs->name,NULL);
-          tmpCheck=getMap(tmpMaps->content,"mimeType");
-          addToMap(tmpMaps->content,"requestedMimeType",tmpCheck->value);
-          map* cursor=tmpIoType->content;
-          while(cursor!=NULL){
-            addToMap(tmpMaps->content,cursor->name,cursor->value);
-            cursor=cursor->next;
-          }
+        if(tmpIoType!=NULL){
+          map* tmpCheck=getMap(tmpIoType->content,"useMapServer");
+          if(tmpCheck!=NULL){
+            // Get the default value
+            tmpIoType=getIoTypeFromElement(tmpInputs,tmpInputs->name,NULL);
+            tmpCheck=getMap(tmpMaps->content,"mimeType");
+            addToMap(tmpMaps->content,"requestedMimeType",tmpCheck->value);
+            map* cursor=tmpIoType->content;
+            while(cursor!=NULL){
+              addToMap(tmpMaps->content,cursor->name,cursor->value);
+              cursor=cursor->next;
+            }
           
-          cursor=tmpInputs->content;
-          while(cursor!=NULL){
-            if(strcasecmp(cursor->name,"Title")==0 ||
-               strcasecmp(cursor->name,"Abstract")==0)
-              addToMap(tmpMaps->content,cursor->name,cursor->value);
-           cursor=cursor->next;
+            cursor=tmpInputs->content;
+            while(cursor!=NULL){
+              if(strcasecmp(cursor->name,"Title")==0 ||
+                 strcasecmp(cursor->name,"Abstract")==0)
+                addToMap(tmpMaps->content,cursor->name,cursor->value);
+              cursor=cursor->next;
+            }
           }
         }