Ticket #83 (closed defect: fixed)

Opened 7 years ago

Last modified 7 years ago

Voronoi diagram not correct for my input

Reported by: giles Owned by:
Priority: major Milestone:
Component: zoo-kernel Version:
Keywords: Cc:

Description

Hi I was using this simple collection of 14 points and the voronoi diagram (displayed in QGIS) has got the far right hand 2 points in a single cell. attached is the gml file and the results.

Attachments (5)

london.gml (5.0 KB) - added by giles 7 years ago.
Input file of 14 points
Zoo_voronoi_results.png (21.0 KB) - added by giles 7 years ago.
Results in QGIS
zoo_voronoi.geojson (4.3 KB) - added by giles 7 years ago.
Results in geojson format
cgal.patch (1.6 KB) - added by djay 7 years ago.
Patch
Zoo_voronoi_results2.png (51.4 KB) - added by giles 7 years ago.
Showing the Rays as well

Download all attachments as: .zip

Change History

Changed 7 years ago by giles

Input file of 14 points

Changed 7 years ago by giles

Results in QGIS

Changed 7 years ago by giles

Results in geojson format

Changed 7 years ago by djay

Patch

Changed 7 years ago by djay

Hi, first of all thanks a lot for your interest in the Voronoi service and for providing such kinf of feedbacks.

I have to conceede that I do not take a look at the CGAL service for long time now. Nevertheless, by searching on the internet I realized that we are nor using any constraint on our computation (based on the data extent) nor treating the rays which may occurs when producing the Voronoi diagram through the CGAL library.

I would like to invite you to apply the patch linked in this page and let me know if it solves your issue with your dataset.

Note that I got 5 rays using your dataset and I treat them in a really stupid manner by now, but this is just for confirming that the rays are well the missing "edges" you were talking about in your original post.

I would like to invite you to let us know if this solves your issue, in this case we may think of trying to provide better solution or use contrained computation. Please take a look at the CGAL Triangulation Documentation

Changed 7 years ago by djay

I forgot to mention that I've setup a brand new ZOO-Kernel on the ZOO-Project server with the patched version of the service and it is available from here :

http://svn.zoo-project.org/cgi-bin/cgal/zoo_loader.cgi

I've also copied your GML data in dl directory so this request should work :

http://svn.zoo-project.org/cgi-bin/cgal/zoo_loader.cgi?request=Execute&service=WPS&version=1.0.0&Identifier=Voronoi&DataInputs=InputPoints=Reference@xlink:href=http://www.zoo-project.org/dl/london.gml&RawDataOutput=Result

Changed 7 years ago by giles

Showing the Rays as well

Changed 7 years ago by giles

Yes! the missing edge is one of the rays - I've attached a picture with them all showing.

Changed 7 years ago by giles

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.

Search

Context Navigation

ZOO Sponsors

http://www.zoo-project.org/trac/chrome/site/img/geolabs-logo.pnghttp://www.zoo-project.org/trac/chrome/site/img/neogeo-logo.png http://www.zoo-project.org/trac/chrome/site/img/apptech-logo.png http://www.zoo-project.org/trac/chrome/site/img/3liz-logo.png http://www.zoo-project.org/trac/chrome/site/img/gateway-logo.png

Become a sponsor !

Knowledge partners

http://www.zoo-project.org/trac/chrome/site/img/ocu-logo.png http://www.zoo-project.org/trac/chrome/site/img/gucas-logo.png http://www.zoo-project.org/trac/chrome/site/img/polimi-logo.png http://www.zoo-project.org/trac/chrome/site/img/fem-logo.png http://www.zoo-project.org/trac/chrome/site/img/supsi-logo.png http://www.zoo-project.org/trac/chrome/site/img/cumtb-logo.png

Become a knowledge partner

Related links

http://zoo-project.org/img/ogclogo.png http://zoo-project.org/img/osgeologo.png